search

FAForever / client

FAF Python Client
GNU General Public License v3.0
74 stars 88 forks source link

QFSFileEngine::open: No file name specified #118

Open IDragonfire opened 9 years ago

IDragonfire commented 9 years ago

I have this in the log

2014-11-03 19:59:15,967 INFO     client._clientwindow                     sending packet to lobby.faforever.com
QFSFileEngine::open: No file name specified
QFSFileEngine::open: No file name specified
QFSFileEngine::open: No file name specified
QFSFileEngine::open: No file name specified
QFSFileEngine::open: No file name specified
Sheeo commented 9 years ago

Could you mention which commithash you're getting this on?

I've been seeing it myself, but I'd like to track down where it was introduced.

IDragonfire commented 9 years ago

If I remembered correctly, I got it also a year ago, where I started with faf.lobby coding ... I think it is a general usage problem with QURL (from Zep?) and nothing from our "new/reborn" commits.

IDragonfire commented 9 years ago

also occure in 5ac75b663f5d7b2caf47c2c54c5f8c41f9b2f6ce also in 2454a3d0c6a1eafe5ba0257c2a600e7d3910efb3

Sheeo commented 9 years ago

I was investigating a bit, tried wrapping QUrl with a decorator that would warn when it's instatiated with a wrong url.

It happens a lot around the codebase that it's instantiated without url, and then the "setHost" etc. methods are called later.

askunix commented 5 years ago

`QStandardItemModel pModel = new QStandardItemModel(); QStandardItem pItem = new QStandardItem;

//QList <MuItemData >dataList;
for(int i = 0; i < userList.count(); ++i){
    QStandardItem *pItem = new QStandardItem;
    MuItemData itemData;
    itemData.username = userList[i];
    itemData.descript = des;
    itemData.iconPath = ico;
    pItem->setData(QVariant::fromValue(itemData), Qt::UserRole+2);
    pModel->appendRow(pItem);
}
MuItemDelegate *pItemDelegate = new MuItemDelegate(this);       //MuItemDelegate
ui->listView_UsreLeftList->setItemDelegate(pItemDelegate);
ui->listView_UsreLeftList->setModel(pModel);`
Sheeo commented 5 years ago

@askunix what?

Gatsik commented 3 years ago

9ce2edc does not close this, it still happens every time someone with avatar writes a message in chat. Because of this: https://github.com/FAForever/client/blob/2d2e935aac611f6f0c41ba330ca2d6e3b37ee96f/src/chat/channel_widget.py#L100-L105