FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
196 stars 121 forks source link

Update installation fails if ICE adapter is still open #1569

Closed Brutus5000 closed 4 years ago

Brutus5000 commented 4 years ago

Describe the bug Sometimes the ICE adapter is still running after the client has been closed. In that case the installation throws an error message that it can not create a file.

To Reproduce Try to keep the ICE adapter alive? - then reinstall

Expected behavior Installation works.

Screenshots If applicable, add screenshots to help explain your problem. image

OS Windows

Idea for solution: Maybe the install4j installer can check that no ICE adapter process is running before installation.

Reported by visionik.

Wanna have the bug fixed quickly? Visit Issue hunt... Issue hunt

1-alex98 commented 4 years ago

Interesting

1-alex98 commented 4 years ago

@visionik said he closed it manually, so maybe try kill ice adapter if user closes client. Well we warn him already if the game is open i guess so that would be ok if u ask me