FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
198 stars 121 forks source link

1.2.0 RC1 - Linux - from full screen to window mode, window does not resize to its original size #1860

Open foodlfg opened 4 years ago

foodlfg commented 4 years ago

Describe the bug When the client is on full screen and i use the window mode button (the second one from right) the window does no go back to its original size, instead it it just stays on full screen but with empty borders around it.

Also, i have to click the window mode button twice to it to work.

Screenshots https://i.imgur.com/OhAnqqK.png https://i.imgur.com/jfC1xcz.png

OS Linux, Ubuntu 20.04 LTS, openjdk-14-jre, Gnome 3

foodlfg commented 4 years ago

probably related to

1842

1-alex98 commented 4 years ago

Well it might be that we leave that for the wile being

tatsujb commented 4 years ago

can't we just have an option to use system borders? or just ditch the remade borders altogether? even people on windows are complaining about them aesthetics and function-wise.

1-alex98 commented 4 years ago

What are they complaining about on windows

1-alex98 commented 4 years ago

Well we kind of know what the issue is here. At least I believe so. @micheljung built a libary that uses a native window for Windows and since windows in full screen on windows are at coordinate -9 -9 or something like that we correct for it and then in linux thats not the case and that is the outcome. Idk something like that....

tatsujb commented 4 years ago

What are they complaining about on windows

sorry I never got notified of this one for some reason : mostly it's "can't tell the top bar and the rest of the client appart" (for what zone to grab and move the window around) "it looks awful" ( _ □ X are miss-aligned, the contrast in button sizes feels off, all items within the top bar are either poorly aligned or laking breathing room) "the area that you can grab to resize is unclear/ capricious"

I guess there weren't too many issues regarding resizing / windows + arrow keys on windows but they weren't particularly happy that it was managed by something else / had a different look either