FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
196 stars 121 forks source link

Avatar not showing up in Java Client user list #1930

Closed FtXCommando closed 3 years ago

FtXCommando commented 4 years ago

I had assigned the Winner of Hearts avatar to MadMax recently and discovered that the avatar icon does not show up in the list of users for whatever reason. All other avatars seem to work fine, and the Winner of Hearts avatar functions perfectly well in the aeolus chat as well as in the python client.

I attached some pictures below. Picture 1 is the python client, picture 2 is it working in aeolus chat (worked in both clients), picture 3 and 4 are showcasing that this specific avatar does not work.

winner1 winner2 winner3 winner4

micheljung commented 4 years ago

maybe some odd image format

1-alex98 commented 4 years ago

No seems to be a normal image

"type": "avatar",
            "id": "136",
            "attributes": {
                "createTime": "2017-03-13T22:18:41Z",
                "filename": "Winner of Hearts.png",
                "tooltip": "Winner of Hearts",
                "updateTime": "2020-07-02T07:50:24Z",
                "url": "https://content.faforever.com/faf/avatars/Winner%20of%20Hearts.png"
            },
1-alex98 commented 4 years ago

Probably got to give it to someone that investigates it or needs to be uploaded on test server

FtXCommando commented 4 years ago

Yeah sure, just write whomever to give it out to over here or on zulip.

Sheikah45 commented 3 years ago

This was because the url for the avatars is from the server and not properly url encoded so the path is "Winner of Hearts.png" rather than "Winner%20of%20Hearts.png" and the string for the image loading done by not the webview is not properly url encoded