search

FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
196 stars 121 forks source link

Fix race condition of matchmaker state #2932

Closed Sheikah45 closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #2932 (1a376a5) into develop (1613daa) will decrease coverage by 0.02%. The diff coverage is 82.27%.

:exclamation: Current head 1a376a5 differs from pull request most recent head 3748675. Consider uploading reports for the commit 3748675 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #2932 +/- ## ============================================= - Coverage 64.34% 64.32% -0.02% + Complexity 4912 4910 -2 ============================================= Files 556 556 Lines 20323 20329 +6 Branches 1100 1101 +1 ============================================= + Hits 13076 13077 +1 - Misses 6614 6619 +5 Partials 633 633 ``` | [Impacted Files](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2932?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [...in/java/com/faforever/client/game/GameService.java](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2932?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9nYW1lL0dhbWVTZXJ2aWNlLmphdmE=) | `64.40% <75.00%> (-0.53%)` | :arrow_down: | | [...client/teammatchmaking/TeamMatchmakingService.java](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2932?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC90ZWFtbWF0Y2htYWtpbmcvVGVhbU1hdGNobWFraW5nU2VydmljZS5qYXZh) | `86.80% <88.88%> (+0.19%)` | :arrow_up: | | [...ent/teammatchmaking/TeamMatchmakingController.java](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2932?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC90ZWFtbWF0Y2htYWtpbmcvVGVhbU1hdGNobWFraW5nQ29udHJvbGxlci5qYXZh) | `95.13% <100.00%> (ø)` | | | [...java/com/faforever/client/util/ConcurrentUtil.java](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2932?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC91dGlsL0NvbmN1cnJlbnRVdGlsLmphdmE=) | `66.66% <100.00%> (ø)` | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2932?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2932?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [1613daa...3748675](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2932?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).