search

FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
196 stars 121 forks source link

Don't dynamically create team and player card controllers #2933

Closed Sheikah45 closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #2933 (af0e69f) into develop (5a236c9) will increase coverage by 0.06%. The diff coverage is 97.91%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #2933 +/- ## ============================================= + Coverage 64.31% 64.38% +0.06% + Complexity 4910 4905 -5 ============================================= Files 556 556 Lines 20329 20301 -28 Branches 1101 1097 -4 ============================================= - Hits 13075 13070 -5 + Misses 6621 6602 -19 + Partials 633 629 -4 ``` | [Impacted Files](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2933?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [.../com/faforever/client/game/TeamCardController.java](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2933?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9nYW1lL1RlYW1DYXJkQ29udHJvbGxlci5qYXZh) | `67.18% <93.75%> (+3.29%)` | :arrow_up: | | [...ain/java/com/faforever/client/domain/GameBean.java](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2933?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9kb21haW4vR2FtZUJlYW4uamF2YQ==) | `87.50% <100.00%> (-0.41%)` | :arrow_down: | | [...om/faforever/client/game/GameDetailController.java](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2933?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9nYW1lL0dhbWVEZXRhaWxDb250cm9sbGVyLmphdmE=) | `88.28% <100.00%> (+10.81%)` | :arrow_up: | | [...m/faforever/client/game/GameTooltipController.java](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2933?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9nYW1lL0dhbWVUb29sdGlwQ29udHJvbGxlci5qYXZh) | `83.33% <100.00%> (+5.07%)` | :arrow_up: | | [...main/java/com/faforever/client/map/MapService.java](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2933?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9tYXAvTWFwU2VydmljZS5qYXZh) | `72.18% <0.00%> (-0.60%)` | :arrow_down: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2933?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2933?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [5a236c9...af0e69f](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2933?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).