search

FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
196 stars 121 forks source link

Ensure game list updated when type updated #2934

Closed Sheikah45 closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #2934 (6480a1f) into develop (1c672a6) will increase coverage by 0.00%. The diff coverage is 97.61%.

:exclamation: Current head 6480a1f differs from pull request most recent head 93a973b. Consider uploading reports for the commit 93a973b to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #2934 +/- ## ========================================== Coverage 64.51% 64.51% + Complexity 4898 4895 -3 ========================================== Files 557 557 Lines 20242 20244 +2 Branches 1080 1080 ========================================== + Hits 13059 13061 +2 + Misses 6565 6564 -1 - Partials 618 619 +1 ``` | [Impacted Files](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2934?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [...orever/client/filter/FilterCheckboxController.java](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2934?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9maWx0ZXIvRmlsdGVyQ2hlY2tib3hDb250cm9sbGVyLmphdmE=) | `100.00% <ø> (ø)` | | | [...r/client/filter/FilterMultiCheckboxController.java](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2934?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9maWx0ZXIvRmlsdGVyTXVsdGlDaGVja2JveENvbnRyb2xsZXIuamF2YQ==) | `94.44% <ø> (ø)` | | | [...rever/client/filter/FilterTextFieldController.java](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2934?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9maWx0ZXIvRmlsdGVyVGV4dEZpZWxkQ29udHJvbGxlci5qYXZh) | `88.88% <ø> (ø)` | | | [...ver/client/filter/MutableListFilterController.java](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2934?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9maWx0ZXIvTXV0YWJsZUxpc3RGaWx0ZXJDb250cm9sbGVyLmphdmE=) | `92.59% <ø> (ø)` | | | [...ver/client/filter/RangeSliderFilterController.java](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2934?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9maWx0ZXIvUmFuZ2VTbGlkZXJGaWx0ZXJDb250cm9sbGVyLmphdmE=) | `78.57% <ø> (ø)` | | | [.../filter/RangeSliderWithChoiceFilterController.java](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2934?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9maWx0ZXIvUmFuZ2VTbGlkZXJXaXRoQ2hvaWNlRmlsdGVyQ29udHJvbGxlci5qYXZh) | `91.17% <ø> (ø)` | | | [...in/java/com/faforever/client/game/GameService.java](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2934?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9nYW1lL0dhbWVTZXJ2aWNlLmphdmE=) | `64.33% <96.15%> (+0.38%)` | :arrow_up: | | [...er/client/filter/AbstractFilterNodeController.java](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2934?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9maWx0ZXIvQWJzdHJhY3RGaWx0ZXJOb2RlQ29udHJvbGxlci5qYXZh) | `100.00% <100.00%> (ø)` | | | [...ver/client/filter/CustomGamesFilterController.java](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2934?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9maWx0ZXIvQ3VzdG9tR2FtZXNGaWx0ZXJDb250cm9sbGVyLmphdmE=) | `100.00% <100.00%> (ø)` | | | [...m/faforever/client/game/CustomGamesController.java](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2934?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9nYW1lL0N1c3RvbUdhbWVzQ29udHJvbGxlci5qYXZh) | `58.49% <100.00%> (-1.15%)` | :arrow_down: | | ... and [2 more](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2934?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2934?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2934?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [1c672a6...93a973b](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2934?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).