FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
196 stars 121 forks source link

Ensure windowprefs navigation item is not bound #2939

Closed Sheikah45 closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #2939 (f43db9f) into develop (d82ab86) will decrease coverage by 0.01%. The diff coverage is 40.00%.

:exclamation: Current head f43db9f differs from pull request most recent head 6189d4b. Consider uploading reports for the commit 6189d4b to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #2939 +/- ## ============================================= - Coverage 64.53% 64.52% -0.01% - Complexity 4895 4896 +1 ============================================= Files 557 557 Lines 20232 20233 +1 Branches 1081 1082 +1 ============================================= - Hits 13057 13056 -1 - Misses 6557 6559 +2 Partials 618 618 ``` | [Impacted Files](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [...java/com/faforever/client/main/MainController.java](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9tYWluL01haW5Db250cm9sbGVyLmphdmE=) | `53.01% <40.00%> (-0.17%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2939/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) ------ [Continue to review full report in Codecov by Sentry](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2939?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2939?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [d82ab86...6189d4b](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2939?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).