search

FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
196 stars 121 forks source link

Use pattern matching where possible #2941

Closed Sheikah45 closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #2941 (b5c63db) into develop (6231023) will increase coverage by 0.00%. The diff coverage is 21.56%.

:exclamation: Current head b5c63db differs from pull request most recent head d365c12. Consider uploading reports for the commit d365c12 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #2941 +/- ## ========================================== Coverage 64.58% 64.58% + Complexity 4887 4885 -2 ========================================== Files 556 556 Lines 20195 20193 -2 Branches 1080 1080 ========================================== - Hits 13043 13042 -1 + Misses 6534 6532 -2 - Partials 618 619 +1 ``` | [Impacted Files](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2941?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [...n/java/com/faforever/client/api/JsonApiWriter.java](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2941?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9hcGkvSnNvbkFwaVdyaXRlci5qYXZh) | `56.25% <0.00%> (ø)` | | | [...java/com/faforever/client/chat/ChatController.java](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2941?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L0NoYXRDb250cm9sbGVyLmphdmE=) | `58.99% <0.00%> (ø)` | | | [...a/com/faforever/client/chat/KittehChatService.java](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2941?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L0tpdHRlaENoYXRTZXJ2aWNlLmphdmE=) | `73.72% <0.00%> (ø)` | | | [...java/com/faforever/client/coop/CoopController.java](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2941?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jb29wL0Nvb3BDb250cm9sbGVyLmphdmE=) | `52.71% <0.00%> (ø)` | | | [...orever/client/discord/JoinDiscordEventHandler.java](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2941?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9kaXNjb3JkL0pvaW5EaXNjb3JkRXZlbnRIYW5kbGVyLmphdmE=) | `10.00% <0.00%> (+0.24%)` | :arrow_up: | | [...rever/client/exception/GlobalExceptionHandler.java](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2941?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9leGNlcHRpb24vR2xvYmFsRXhjZXB0aW9uSGFuZGxlci5qYXZh) | `12.50% <0.00%> (ø)` | | | [...om/faforever/client/game/CreateGameController.java](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2941?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9nYW1lL0NyZWF0ZUdhbWVDb250cm9sbGVyLmphdmE=) | `72.04% <0.00%> (ø)` | | | [...m/faforever/client/game/CustomGamesController.java](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2941?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9nYW1lL0N1c3RvbUdhbWVzQ29udHJvbGxlci5qYXZh) | `58.49% <0.00%> (ø)` | | | [...in/java/com/faforever/client/game/GameService.java](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2941?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9nYW1lL0dhbWVTZXJ2aWNlLmphdmE=) | `64.33% <0.00%> (ø)` | | | [...ver/client/leaderboard/LeaderboardsController.java](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2941?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9sZWFkZXJib2FyZC9MZWFkZXJib2FyZHNDb250cm9sbGVyLmphdmE=) | `86.04% <0.00%> (-0.32%)` | :arrow_down: | | ... and [6 more](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2941?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | | ... and [2 files with indirect coverage changes](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2941/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) ------ [Continue to review full report in Codecov by Sentry](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2941?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2941?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [6231023...d365c12](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2941?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).