search

FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
196 stars 121 forks source link

Use properties for chat channel controller and ensure it can be collected #2960

Closed Sheikah45 closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #2960 (58e5b48) into develop (acf47e3) will decrease coverage by 0.07%. The diff coverage is 74.72%.

:exclamation: Current head 58e5b48 differs from pull request most recent head ac640d3. Consider uploading reports for the commit ac640d3 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #2960 +/- ## ============================================= - Coverage 64.77% 64.71% -0.07% - Complexity 4895 4897 +2 ============================================= Files 556 556 Lines 20233 20261 +28 Branches 1080 1084 +4 ============================================= + Hits 13106 13111 +5 - Misses 6500 6518 +18 - Partials 627 632 +5 ``` | [Impacted Files](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2960?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [...n/java/com/faforever/client/chat/ChatListItem.java](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2960?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L0NoYXRMaXN0SXRlbS5qYXZh) | `0.00% <ø> (ø)` | | | [...va/com/faforever/client/chat/ChatListItemCell.java](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2960?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L0NoYXRMaXN0SXRlbUNlbGwuamF2YQ==) | `0.00% <0.00%> (ø)` | | | [...ver/client/player/PrivatePlayerInfoController.java](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2960?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9wbGF5ZXIvUHJpdmF0ZVBsYXllckluZm9Db250cm9sbGVyLmphdmE=) | `89.02% <0.00%> (-2.23%)` | :arrow_down: | | [...ent/teammatchmaking/TeamMatchmakingController.java](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2960?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC90ZWFtbWF0Y2htYWtpbmcvVGVhbU1hdGNobWFraW5nQ29udHJvbGxlci5qYXZh) | `95.13% <50.00%> (ø)` | | | [...java/com/faforever/client/chat/ChatController.java](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2960?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L0NoYXRDb250cm9sbGVyLmphdmE=) | `58.99% <66.66%> (ø)` | | | [...orever/client/chat/ChatCategoryItemController.java](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2960?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L0NoYXRDYXRlZ29yeUl0ZW1Db250cm9sbGVyLmphdmE=) | `76.27% <70.37%> (-7.41%)` | :arrow_down: | | [...forever/client/chat/MatchmakingChatController.java](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2960?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L01hdGNobWFraW5nQ2hhdENvbnRyb2xsZXIuamF2YQ==) | `72.91% <72.22%> (-1.45%)` | :arrow_down: | | [.../faforever/client/chat/ChatUserListController.java](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2960?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L0NoYXRVc2VyTGlzdENvbnRyb2xsZXIuamF2YQ==) | `90.67% <78.57%> (+3.58%)` | :arrow_up: | | [...forever/client/chat/AbstractChatTabController.java](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2960?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L0Fic3RyYWN0Q2hhdFRhYkNvbnRyb2xsZXIuamF2YQ==) | `74.92% <78.94%> (-0.38%)` | :arrow_down: | | [.../faforever/client/chat/ChatUserItemController.java](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2960?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L0NoYXRVc2VySXRlbUNvbnRyb2xsZXIuamF2YQ==) | `87.68% <80.64%> (-0.61%)` | :arrow_down: | | ... and [6 more](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2960?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | | ... and [2 files with indirect coverage changes](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2960/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) ------ [Continue to review full report in Codecov by Sentry](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2960?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2960?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [acf47e3...ac640d3](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2960?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).