FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
197 stars 121 forks source link

Don't recreate games container every switch #2962

Closed Sheikah45 closed 1 year ago

Sheikah45 commented 1 year ago

Closes #2954

codecov[bot] commented 1 year ago

Codecov Report

Merging #2962 (b90efc1) into develop (b86f5c8) will increase coverage by 0.01%. The diff coverage is 77.27%.

:exclamation: Current head b90efc1 differs from pull request most recent head bf59420. Consider uploading reports for the commit bf59420 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #2962 +/- ## ============================================= + Coverage 64.72% 64.73% +0.01% - Complexity 4880 4882 +2 ============================================= Files 554 555 +1 Lines 20217 20204 -13 Branches 1081 1080 -1 ============================================= - Hits 13085 13080 -5 + Misses 6501 6493 -8 Partials 631 631 ``` | [Impacted Files](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2962?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [...com/faforever/client/fx/ToStringOnlyConverter.java](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2962?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9meC9Ub1N0cmluZ09ubHlDb252ZXJ0ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | | | [...om/faforever/client/game/GameDetailController.java](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2962?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9nYW1lL0dhbWVEZXRhaWxDb250cm9sbGVyLmphdmE=) | `90.29% <50.00%> (+0.51%)` | :arrow_up: | | [...m/faforever/client/game/CustomGamesController.java](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2962?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9nYW1lL0N1c3RvbUdhbWVzQ29udHJvbGxlci5qYXZh) | `60.41% <93.75%> (+1.92%)` | :arrow_up: | | [...ver/client/game/GamesTilesContainerController.java](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2962?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9nYW1lL0dhbWVzVGlsZXNDb250YWluZXJDb250cm9sbGVyLmphdmE=) | `68.00% <100.00%> (+1.98%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2962/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) ------ [Continue to review full report in Codecov by Sentry](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2962?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2962?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [8a72c8f...bf59420](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2962?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).