search

FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
195 stars 121 forks source link

Don't use deprecated spring security and share webclient #2965

Closed Sheikah45 closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #2965 (bd48a25) into develop (a4a58ac) will decrease coverage by 0.22%. The diff coverage is 70.09%.

:exclamation: Current head bd48a25 differs from pull request most recent head e43e411. Consider uploading reports for the commit e43e411 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #2965 +/- ## ============================================= - Coverage 62.51% 62.30% -0.22% + Complexity 4722 4683 -39 ============================================= Files 556 556 Lines 20298 20248 -50 Branches 1092 1091 -1 ============================================= - Hits 12690 12615 -75 - Misses 6993 7016 +23 - Partials 615 617 +2 ``` | [Impacted Files](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2965?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [...a/com/faforever/client/config/WebClientConfig.java](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2965?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jb25maWcvV2ViQ2xpZW50Q29uZmlnLmphdmE=) | `0.00% <0.00%> (ø)` | | | [...er/client/fa/debugger/DownloadFAFDebuggerTask.java](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2965?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9mYS9kZWJ1Z2dlci9Eb3dubG9hZEZBRkRlYnVnZ2VyVGFzay5qYXZh) | `2.77% <0.00%> (ø)` | | | [...aforever/client/update/CheckForBetaUpdateTask.java](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2965?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC91cGRhdGUvQ2hlY2tGb3JCZXRhVXBkYXRlVGFzay5qYXZh) | `3.22% <0.00%> (+0.28%)` | :arrow_up: | | [...ever/client/map/generator/MapGeneratorService.java](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2965?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9tYXAvZ2VuZXJhdG9yL01hcEdlbmVyYXRvclNlcnZpY2UuamF2YQ==) | `54.44% <50.00%> (-4.15%)` | :arrow_down: | | [...in/java/com/faforever/client/user/UserService.java](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2965?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC91c2VyL1VzZXJTZXJ2aWNlLmphdmE=) | `79.10% <82.75%> (-1.50%)` | :arrow_down: | | [...in/java/com/faforever/client/api/TokenService.java](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2965?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9hcGkvVG9rZW5TZXJ2aWNlLmphdmE=) | `97.05% <97.29%> (-2.95%)` | :arrow_down: | | [.../java/com/faforever/client/api/FafApiAccessor.java](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2965?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9hcGkvRmFmQXBpQWNjZXNzb3IuamF2YQ==) | `99.35% <100.00%> (+1.65%)` | :arrow_up: | | [.../java/com/faforever/client/io/DownloadService.java](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2965?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9pby9Eb3dubG9hZFNlcnZpY2UuamF2YQ==) | `92.30% <100.00%> (ø)` | | | [...va/com/faforever/client/login/LoginController.java](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2965?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9sb2dpbi9Mb2dpbkNvbnRyb2xsZXIuamF2YQ==) | `87.64% <100.00%> (ø)` | | | [...om/faforever/client/login/OAuthValuesReceiver.java](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2965?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9sb2dpbi9PQXV0aFZhbHVlc1JlY2VpdmVyLmphdmE=) | `94.28% <100.00%> (+1.13%)` | :arrow_up: | ... and [6 files with indirect coverage changes](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2965/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) ------ [Continue to review full report in Codecov by Sentry](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2965?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2965?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [a4a58ac...e43e411](https://codecov.io/gh/FAForever/downlords-faf-client/pull/2965?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).