search

FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
195 stars 121 forks source link

Retry on 429 #2969

Closed Sheikah45 closed 1 year ago

Sheikah45 commented 1 year ago

We added rate limiting to the api so we should handle it properly

codecov[bot] commented 1 year ago

Codecov Report

Merging #2969 (f589a03) into develop (105ef8c) will decrease coverage by 0.11%. The diff coverage is 88.00%.

:exclamation: Current head f589a03 differs from pull request most recent head 5b89480. Consider uploading reports for the commit 5b89480 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #2969 +/- ## ============================================= - Coverage 62.30% 62.19% -0.11% + Complexity 4684 4683 -1 ============================================= Files 556 557 +1 Lines 20248 20212 -36 Branches 1091 1092 +1 ============================================= - Hits 12615 12571 -44 - Misses 7017 7022 +5 - Partials 616 619 +3 ``` | [Impacted Files](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2969?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [...om/faforever/client/api/RateLimitApiException.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2969?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9hcGkvUmF0ZUxpbWl0QXBpRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | | | [.../java/com/faforever/client/api/FafApiAccessor.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2969?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9hcGkvRmFmQXBpQWNjZXNzb3IuamF2YQ==) | `95.72% <91.66%> (-3.63%)` | :arrow_down: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2969/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2969?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2969?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [105ef8c...5b89480](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2969?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).