search

FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
195 stars 121 forks source link

Don't use subscribe for custom games controller and use properties #2970

Closed Sheikah45 closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #2970 (ff1468a) into develop (52a3217) will decrease coverage by 0.21%. The diff coverage is 86.15%.

:exclamation: Current head ff1468a differs from pull request most recent head 0f15b7d. Consider uploading reports for the commit 0f15b7d to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #2970 +/- ## ============================================= - Coverage 62.09% 61.88% -0.21% + Complexity 4711 4672 -39 ============================================= Files 558 558 Lines 20327 20320 -7 Branches 1067 1066 -1 ============================================= - Hits 12623 12576 -47 - Misses 7091 7142 +51 + Partials 613 602 -11 ``` | [Impacted Files](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2970?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [...ver/client/game/GamesTilesContainerController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2970?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9nYW1lL0dhbWVzVGlsZXNDb250YWluZXJDb250cm9sbGVyLmphdmE=) | `74.44% <ø> (+6.44%)` | :arrow_up: | | [...main/java/com/faforever/client/map/MapService.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2970?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9tYXAvTWFwU2VydmljZS5qYXZh) | `70.44% <0.00%> (-0.22%)` | :arrow_down: | | [...om/faforever/client/game/GamesTableController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2970?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9nYW1lL0dhbWVzVGFibGVDb250cm9sbGVyLmphdmE=) | `62.39% <65.21%> (-13.08%)` | :arrow_down: | | [...m/faforever/client/game/CustomGamesController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2970?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9nYW1lL0N1c3RvbUdhbWVzQ29udHJvbGxlci5qYXZh) | `58.82% <100.00%> (-1.60%)` | :arrow_down: | | [.../com/faforever/client/game/GameTileController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2970?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9nYW1lL0dhbWVUaWxlQ29udHJvbGxlci5qYXZh) | `98.36% <100.00%> (+0.05%)` | :arrow_up: | ... and [7 files with indirect coverage changes](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2970/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2970?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2970?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [52a3217...0f15b7d](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2970?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).