search

FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
195 stars 121 forks source link

Make properties sortable #2972

Closed Sheikah45 closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #2972 (f8dae90) into develop (ed3b029) will decrease coverage by 0.01%. The diff coverage is 83.92%.

:exclamation: Current head f8dae90 differs from pull request most recent head 9b43b11. Consider uploading reports for the commit 9b43b11 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #2972 +/- ## ============================================= - Coverage 62.15% 62.14% -0.01% - Complexity 4698 4700 +2 ============================================= Files 557 557 Lines 20303 20298 -5 Branches 1065 1061 -4 ============================================= - Hits 12619 12615 -4 - Misses 7076 7079 +3 + Partials 608 604 -4 ``` | [Impacted Files](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2972?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [...a/com/faforever/client/map/MapVaultController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2972?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9tYXAvTWFwVmF1bHRDb250cm9sbGVyLmphdmE=) | `66.66% <ø> (ø)` | | | [...aforever/client/query/SpecificationController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2972?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9xdWVyeS9TcGVjaWZpY2F0aW9uQ29udHJvbGxlci5qYXZh) | `83.15% <0.00%> (ø)` | | | [...aforever/client/vault/search/SearchController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2972?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC92YXVsdC9zZWFyY2gvU2VhcmNoQ29udHJvbGxlci5qYXZh) | `55.65% <46.66%> (-0.39%)` | :arrow_down: | | [...main/java/com/faforever/client/map/MapService.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2972?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9tYXAvTWFwU2VydmljZS5qYXZh) | `70.44% <100.00%> (-0.60%)` | :arrow_down: | | [...main/java/com/faforever/client/mod/ModService.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2972?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9tb2QvTW9kU2VydmljZS5qYXZh) | `76.38% <100.00%> (ø)` | | | [...rever/client/query/SearchablePropertyMappings.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2972?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9xdWVyeS9TZWFyY2hhYmxlUHJvcGVydHlNYXBwaW5ncy5qYXZh) | `98.18% <100.00%> (+1.63%)` | :arrow_up: | | [...ava/com/faforever/client/replay/ReplayService.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2972?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9yZXBsYXkvUmVwbGF5U2VydmljZS5qYXZh) | `80.73% <100.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2972/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2972?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2972?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [ed3b029...9b43b11](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2972?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).