search

FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
195 stars 121 forks source link

Use new reconnect #2974

Closed Sheikah45 closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #2974 (e295ba6) into develop (b4bc74e) will decrease coverage by 0.01%. The diff coverage is 71.42%.

:exclamation: Current head e295ba6 differs from pull request most recent head dc37cb0. Consider uploading reports for the commit dc37cb0 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #2974 +/- ## ============================================= - Coverage 62.13% 62.13% -0.01% - Complexity 4699 4700 +1 ============================================= Files 557 557 Lines 20298 20290 -8 Branches 1061 1061 ============================================= - Hits 12613 12608 -5 + Misses 7080 7079 -1 + Partials 605 603 -2 ``` | [Impacted Files](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2974?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [...in/java/com/faforever/client/user/UserService.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2974?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC91c2VyL1VzZXJTZXJ2aWNlLmphdmE=) | `79.10% <50.00%> (ø)` | | | [...com/faforever/client/remote/FafServerAccessor.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2974?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9yZW1vdGUvRmFmU2VydmVyQWNjZXNzb3IuamF2YQ==) | `76.22% <77.77%> (-0.60%)` | :arrow_down: | | [.../com/faforever/client/config/ClientProperties.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2974?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jb25maWcvQ2xpZW50UHJvcGVydGllcy5qYXZh) | `53.60% <100.00%> (ø)` | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2974/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2974?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2974?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [b4bc74e...dc37cb0](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2974?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).