search

FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
195 stars 121 forks source link

Replace isPresent where possible #2980

Closed Sheikah45 closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #2980 (0bf482a) into develop (984fae6) will increase coverage by 0.00%. The diff coverage is 83.33%.

:exclamation: Current head 0bf482a differs from pull request most recent head 0b9d0f7. Consider uploading reports for the commit 0b9d0f7 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #2980 +/- ## ========================================== Coverage 62.07% 62.08% + Complexity 4699 4696 -3 ========================================== Files 558 558 Lines 20286 20275 -11 Branches 1058 1053 -5 ========================================== - Hits 12593 12588 -5 + Misses 7089 7087 -2 + Partials 604 600 -4 ``` | [Impacted Files](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2980?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [...a/com/faforever/client/chat/KittehChatService.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2980?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L0tpdHRlaENoYXRTZXJ2aWNlLmphdmE=) | `72.86% <42.85%> (+0.28%)` | :arrow_up: | | [...aforever/client/chat/PrivateChatTabController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2980?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L1ByaXZhdGVDaGF0VGFiQ29udHJvbGxlci5qYXZh) | `75.00% <75.00%> (+0.80%)` | :arrow_up: | | [.../com/faforever/client/ui/tray/TrayIconManager.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2980?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC91aS90cmF5L1RyYXlJY29uTWFuYWdlci5qYXZh) | `85.71% <75.00%> (+1.71%)` | :arrow_up: | | [...main/java/com/faforever/client/mod/ModService.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2980?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9tb2QvTW9kU2VydmljZS5qYXZh) | `77.00% <80.00%> (+0.61%)` | :arrow_up: | | [...forever/client/chat/AbstractChatTabController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2980?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L0Fic3RyYWN0Q2hhdFRhYkNvbnRyb2xsZXIuamF2YQ==) | `74.32% <100.00%> (-0.09%)` | :arrow_down: | | [...om/faforever/client/chat/ChannelTabController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2980?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L0NoYW5uZWxUYWJDb250cm9sbGVyLmphdmE=) | `88.95% <100.00%> (+0.48%)` | :arrow_up: | | [...main/java/com/faforever/client/map/MapService.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2980?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9tYXAvTWFwU2VydmljZS5qYXZh) | `70.44% <100.00%> (ø)` | | | [...ent/ui/tray/event/UpdateApplicationBadgeEvent.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2980?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC91aS90cmF5L2V2ZW50L1VwZGF0ZUFwcGxpY2F0aW9uQmFkZ2VFdmVudC5qYXZh) | `100.00% <100.00%> (ø)` | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2980?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2980?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [984fae6...0b9d0f7](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2980?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).