search

FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
195 stars 121 forks source link

Rework javafxutil static calls #2982

Closed Sheikah45 closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #2982 (042a408) into develop (8f8e2eb) will decrease coverage by 0.72%. The diff coverage is 77.91%.

:exclamation: Current head 042a408 differs from pull request most recent head 8c917ad. Consider uploading reports for the commit 8c917ad to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #2982 +/- ## ============================================= - Coverage 62.09% 61.38% -0.72% + Complexity 4695 4598 -97 ============================================= Files 558 558 Lines 20275 20205 -70 Branches 1053 1049 -4 ============================================= - Hits 12590 12402 -188 - Misses 7086 7218 +132 + Partials 599 585 -14 ``` | [Impacted Files](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2982?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [...ava/com/faforever/client/FafClientApplication.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2982?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9GYWZDbGllbnRBcHBsaWNhdGlvbi5qYXZh) | `3.07% <ø> (+0.04%)` | :arrow_up: | | [...main/java/com/faforever/client/StartupService.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2982?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9TdGFydHVwU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | | | [...com/faforever/client/config/PreferencesConfig.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2982?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jb25maWcvUHJlZmVyZW5jZXNDb25maWcuamF2YQ==) | `0.00% <0.00%> (ø)` | | | [.../java/com/faforever/client/fx/BrowserCallback.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2982?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9meC9Ccm93c2VyQ2FsbGJhY2suamF2YQ==) | `14.28% <0.00%> (ø)` | | | [...va/com/faforever/client/fx/DualStringListCell.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2982?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9meC9EdWFsU3RyaW5nTGlzdENlbGwuamF2YQ==) | `0.00% <0.00%> (ø)` | | | [...va/com/faforever/client/fx/IconButtonListCell.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2982?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9meC9JY29uQnV0dG9uTGlzdENlbGwuamF2YQ==) | `0.00% <0.00%> (ø)` | | | [.../java/com/faforever/client/fx/PlatformService.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2982?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9meC9QbGF0Zm9ybVNlcnZpY2UuamF2YQ==) | `1.44% <0.00%> (ø)` | | | [...java/com/faforever/client/game/JoinGameHelper.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2982?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9nYW1lL0pvaW5HYW1lSGVscGVyLmphdmE=) | `66.66% <0.00%> (ø)` | | | [...com/faforever/client/mod/ModManagerController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2982?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9tb2QvTW9kTWFuYWdlckNvbnRyb2xsZXIuamF2YQ==) | `58.46% <0.00%> (-0.92%)` | :arrow_down: | | [...java/com/faforever/client/news/NewsController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2982?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9uZXdzL05ld3NDb250cm9sbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | | | ... and [76 more](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2982?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | | ... and [14 files with indirect coverage changes](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2982/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2982?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2982?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [8f8e2eb...8c917ad](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2982?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).