search

FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
195 stars 121 forks source link

Use precomputed coturn values #2985

Closed Sheikah45 closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #2985 (2c27caa) into develop (550b34f) will decrease coverage by 0.03%. The diff coverage is 100.00%.

:exclamation: Current head 2c27caa differs from pull request most recent head 9b82ac0. Consider uploading reports for the commit 9b82ac0 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #2985 +/- ## ============================================= - Coverage 61.37% 61.34% -0.03% Complexity 4598 4598 ============================================= Files 558 557 -1 Lines 20205 20191 -14 Branches 1049 1048 -1 ============================================= - Hits 12400 12387 -13 Misses 7220 7220 + Partials 585 584 -1 ``` | [Impacted Files](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2985?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [...m/faforever/client/fa/relay/ice/CoturnService.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2985?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9mYS9yZWxheS9pY2UvQ290dXJuU2VydmljZS5qYXZh) | `100.00% <100.00%> (ø)` | | | [...om/faforever/client/mapstruct/IceServerMapper.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2985?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9tYXBzdHJ1Y3QvSWNlU2VydmVyTWFwcGVyLmphdmE=) | `100.00% <100.00%> (+5.26%)` | :arrow_up: | | [...orever/client/preferences/ForgedAlliancePrefs.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2985?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9wcmVmZXJlbmNlcy9Gb3JnZWRBbGxpYW5jZVByZWZzLmphdmE=) | `78.46% <100.00%> (ø)` | | | [...ever/client/preferences/ui/SettingsController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2985?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9wcmVmZXJlbmNlcy91aS9TZXR0aW5nc0NvbnRyb2xsZXIuamF2YQ==) | `81.51% <100.00%> (ø)` | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2985?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2985?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [550b34f...9b82ac0](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2985?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).