search

FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
195 stars 121 forks source link

Cache random faction image #2986

Closed Sheikah45 closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #2986 (f495a8f) into develop (bec19fc) will decrease coverage by 0.01%. The diff coverage is 60.00%.

:exclamation: Current head f495a8f differs from pull request most recent head 8a4d4d5. Consider uploading reports for the commit 8a4d4d5 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #2986 +/- ## ============================================= - Coverage 61.35% 61.35% -0.01% + Complexity 4599 4597 -2 ============================================= Files 557 557 Lines 20191 20192 +1 Branches 1048 1048 ============================================= - Hits 12389 12388 -1 - Misses 7219 7220 +1 - Partials 583 584 +1 ``` | [Impacted Files](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2986?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [.../java/com/faforever/client/config/CacheConfig.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2986?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jb25maWcvQ2FjaGVDb25maWcuamF2YQ==) | `0.00% <0.00%> (ø)` | | | [...n/java/com/faforever/client/config/CacheNames.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2986?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jb25maWcvQ2FjaGVOYW1lcy5qYXZh) | `0.00% <ø> (ø)` | | | [...ain/java/com/faforever/client/theme/UiService.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2986?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC90aGVtZS9VaVNlcnZpY2UuamF2YQ==) | `0.85% <0.00%> (-0.01%)` | :arrow_down: | | [...om/faforever/client/game/PlayerCardController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2986?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9nYW1lL1BsYXllckNhcmRDb250cm9sbGVyLmphdmE=) | `83.15% <100.00%> (ø)` | | | [...com/faforever/client/remote/FafServerAccessor.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2986?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9yZW1vdGUvRmFmU2VydmVyQWNjZXNzb3IuamF2YQ==) | `74.81% <100.00%> (-0.19%)` | :arrow_down: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2986/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2986?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2986?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [bec19fc...8a4d4d5](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2986?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).