FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
195 stars 121 forks source link

Fix race condition with review supplier for replays #2990

Closed Sheikah45 closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #2990 (191f93b) into develop (5f65e3a) will decrease coverage by 0.06%. The diff coverage is 0.00%.

:exclamation: Current head 191f93b differs from pull request most recent head 7facdbf. Consider uploading reports for the commit 7facdbf to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #2990 +/- ## ============================================= - Coverage 61.33% 61.28% -0.06% + Complexity 4594 4590 -4 ============================================= Files 557 557 Lines 20185 20186 +1 Branches 1048 1048 ============================================= - Hits 12381 12371 -10 - Misses 7218 7228 +10 - Partials 586 587 +1 ``` | [Impacted Files](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2990?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [...forever/client/vault/review/ReviewsController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2990?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC92YXVsdC9yZXZpZXcvUmV2aWV3c0NvbnRyb2xsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2990/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2990?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2990?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [5f65e3a...7facdbf](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2990?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).