FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
195 stars 121 forks source link

Rework display of ratings in player info window #2991

Open BlackYps opened 1 year ago

BlackYps commented 1 year ago

The order of ratings doesn't match the order in the leaderboard tab of the client. 3v3 is listed last. Additionally the unused 4v4 share until death rating should be hidden. Maybe we should entirely rework how the display of ratings works in this window. Currently all the leaderboards get fetched, but the leaderboards don't have a flag if they are active, only the leagues have. If we rework it to fetch the leagues like in the leaderboard tab, then we can be consistent. The only question is how we want to treat global rating. grafik

Brutus5000 commented 1 year ago

This is more than a client issue. There is no sort order defined, so the response can come in any order (usually order of last insertion/update). If you want a sorting you need to add it to the db, api and then sort by it in the client.