FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
195 stars 121 forks source link

Use reactor for UserService #2996

Closed Sheikah45 closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #2996 (91a4c97) into develop (ef8b32a) will decrease coverage by 0.07%. The diff coverage is 57.14%.

:exclamation: Current head 91a4c97 differs from pull request most recent head 74bd79a. Consider uploading reports for the commit 74bd79a to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #2996 +/- ## ============================================= - Coverage 61.43% 61.36% -0.07% + Complexity 4590 4586 -4 ============================================= Files 556 556 Lines 20142 20119 -23 Branches 1046 1043 -3 ============================================= - Hits 12375 12347 -28 - Misses 7181 7192 +11 + Partials 586 580 -6 ``` | [Impacted Files](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2996?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [...a/com/faforever/client/chat/KittehChatService.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2996?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L0tpdHRlaENoYXRTZXJ2aWNlLmphdmE=) | `63.03% <0.00%> (-9.84%)` | :arrow_down: | | [...com/faforever/client/remote/FafServerAccessor.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2996?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9yZW1vdGUvRmFmU2VydmVyQWNjZXNzb3IuamF2YQ==) | `80.15% <25.00%> (+5.34%)` | :arrow_up: | | [...in/java/com/faforever/client/user/UserService.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2996?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC91c2VyL1VzZXJTZXJ2aWNlLmphdmE=) | `75.43% <60.00%> (-5.99%)` | :arrow_down: | | [.../java/com/faforever/client/api/FafApiAccessor.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2996?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9hcGkvRmFmQXBpQWNjZXNzb3IuamF2YQ==) | `92.94% <100.00%> (ø)` | | | [...va/com/faforever/client/login/LoginController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2996?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9sb2dpbi9Mb2dpbkNvbnRyb2xsZXIuamF2YQ==) | `87.64% <100.00%> (ø)` | | | [...om/faforever/client/main/UserButtonController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2996?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9tYWluL1VzZXJCdXR0b25Db250cm9sbGVyLmphdmE=) | `81.81% <100.00%> (ø)` | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2996/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2996?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2996?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [ef8b32a...74bd79a](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2996?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).