search

FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
195 stars 121 forks source link

Remove event bus usage for login events #2997

Closed Sheikah45 closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #2997 (3b3955c) into develop (3392be5) will increase coverage by 0.06%. The diff coverage is 69.62%.

:exclamation: Current head 3b3955c differs from pull request most recent head 384cbd3. Consider uploading reports for the commit 384cbd3 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #2997 +/- ## ============================================= + Coverage 61.31% 61.37% +0.06% - Complexity 4582 4583 +1 ============================================= Files 556 551 -5 Lines 20119 20107 -12 Branches 1043 1045 +2 ============================================= + Hits 12335 12340 +5 + Misses 7204 7183 -21 - Partials 580 584 +4 ``` | [Impacted Files](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2997?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [...ava/com/faforever/client/FafClientApplication.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2997?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9GYWZDbGllbnRBcHBsaWNhdGlvbi5qYXZh) | `2.94% <0.00%> (-0.19%)` | :arrow_down: | | [...ava/com/faforever/client/api/OAuthTokenFilter.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2997?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9hcGkvT0F1dGhUb2tlbkZpbHRlci5qYXZh) | `0.00% <0.00%> (ø)` | | | [.../main/java/com/faforever/client/fx/JavaFxUtil.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2997?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9meC9KYXZhRnhVdGlsLmphdmE=) | `68.71% <ø> (+6.39%)` | :arrow_up: | | [...ava/com/faforever/client/game/GamePathHandler.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2997?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9nYW1lL0dhbWVQYXRoSGFuZGxlci5qYXZh) | `25.00% <0.00%> (-2.09%)` | :arrow_down: | | [...aforever/client/login/NoRefreshTokenException.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2997?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9sb2dpbi9Ob1JlZnJlc2hUb2tlbkV4Y2VwdGlvbi5qYXZh) | `100.00% <ø> (ø)` | | | [...forever/client/preferences/PreferencesService.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2997?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9wcmVmZXJlbmNlcy9QcmVmZXJlbmNlc1NlcnZpY2UuamF2YQ==) | `11.29% <0.00%> (ø)` | | | [.../com/faforever/client/replay/ReplayServerImpl.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2997?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9yZXBsYXkvUmVwbGF5U2VydmVySW1wbC5qYXZh) | `0.00% <0.00%> (ø)` | | | [...client/teammatchmaking/TeamMatchmakingService.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2997?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC90ZWFtbWF0Y2htYWtpbmcvVGVhbU1hdGNobWFraW5nU2VydmljZS5qYXZh) | `87.02% <16.66%> (ø)` | | | [...va/com/faforever/client/game/VaultPathHandler.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2997?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9nYW1lL1ZhdWx0UGF0aEhhbmRsZXIuamF2YQ==) | `56.66% <20.00%> (-15.21%)` | :arrow_down: | | [...a/com/faforever/client/chat/KittehChatService.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2997?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L0tpdHRlaENoYXRTZXJ2aWNlLmphdmE=) | `62.92% <34.61%> (-0.12%)` | :arrow_down: | | ... and [24 more](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2997?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2997/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2997?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2997?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [3392be5...384cbd3](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/2997?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).