search

FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
195 stars 121 forks source link

Break header into its own component parts #3002

Closed Sheikah45 closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #3002 (dcc64e0) into develop (7ef58fa) will increase coverage by 0.00%. The diff coverage is 63.77%.

:exclamation: Current head dcc64e0 differs from pull request most recent head f269f14. Consider uploading reports for the commit f269f14 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3002 +/- ## ========================================== Coverage 61.33% 61.34% - Complexity 4582 4591 +9 ========================================== Files 551 554 +3 Lines 20118 20131 +13 Branches 1045 1044 -1 ========================================== + Hits 12340 12349 +9 - Misses 7194 7197 +3 - Partials 584 585 +1 ``` | [Impacted Files](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3002?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [...forever/client/headerbar/UserButtonController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3002?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9oZWFkZXJiYXIvVXNlckJ1dHRvbkNvbnRyb2xsZXIuamF2YQ==) | `81.81% <ø> (ø)` | | | [...va/com/faforever/client/login/LoginController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3002?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9sb2dpbi9Mb2dpbkNvbnRyb2xsZXIuamF2YQ==) | `87.50% <ø> (-0.15%)` | :arrow_down: | | [.../faforever/client/main/LinksAndHelpController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3002?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9tYWluL0xpbmtzQW5kSGVscENvbnRyb2xsZXIuamF2YQ==) | `0.00% <ø> (ø)` | | | [...ver/client/headerbar/MainMenuButtonController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3002?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9oZWFkZXJiYXIvTWFpbk1lbnVCdXR0b25Db250cm9sbGVyLmphdmE=) | `30.00% <30.00%> (ø)` | | | [...ent/teammatchmaking/TeamMatchmakingController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3002?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC90ZWFtbWF0Y2htYWtpbmcvVGVhbU1hdGNobWFraW5nQ29udHJvbGxlci5qYXZh) | `91.46% <50.00%> (-0.84%)` | :arrow_down: | | [...aforever/client/headerbar/HeaderBarController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3002?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9oZWFkZXJiYXIvSGVhZGVyQmFyQ29udHJvbGxlci5qYXZh) | `78.18% <78.18%> (ø)` | | | [...client/headerbar/NotificationButtonController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3002?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9oZWFkZXJiYXIvTm90aWZpY2F0aW9uQnV0dG9uQ29udHJvbGxlci5qYXZh) | `84.61% <84.61%> (ø)` | | | [...java/com/faforever/client/main/MainController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3002?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9tYWluL01haW5Db250cm9sbGVyLmphdmE=) | `50.00% <100.00%> (-3.36%)` | :arrow_down: | | [...n/java/com/faforever/client/user/LoginService.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3002?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC91c2VyL0xvZ2luU2VydmljZS5qYXZh) | `74.60% <100.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3002/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3002?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3002?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [6d1880e...f269f14](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3002?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).