FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
195 stars 121 forks source link

Don't use ZGC on win7 or win8 #3003

Closed Sheikah45 closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #3003 (5dac977) into develop (a857a0d) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 5dac977 differs from pull request most recent head dc51d77. Consider uploading reports for the commit dc51d77 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3003 +/- ## ========================================== Coverage 61.35% 61.35% - Complexity 4590 4591 +1 ========================================== Files 554 554 Lines 20132 20132 Branches 1044 1044 ========================================== Hits 12352 12352 - Misses 7194 7195 +1 + Partials 586 585 -1 ``` [see 2 files with indirect coverage changes](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3003/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3003?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3003?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [a857a0d...dc51d77](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3003?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).
micheljung commented 1 year ago

Would be good if you explained the motivation behind it in the commit message.

bukajsytlos commented 1 year ago

will this change affect Linux users?

Sheikah45 commented 1 year ago

Zgc is only supported on windows builds greater than win 10 1803 due to older versions lacking a newer windows memory API.

It does not affect Linux users because they don't use install4j and manage their own vmoptions