search

FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
195 stars 121 forks source link

Use fx:define and load fxml in separate thread where possible for play tab #3009

Closed Sheikah45 closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #3009 (b195d31) into develop (a8bb3b7) will increase coverage by 0.02%. The diff coverage is 77.69%.

:exclamation: Current head b195d31 differs from pull request most recent head f5804ad. Consider uploading reports for the commit f5804ad to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3009 +/- ## ============================================= + Coverage 61.35% 61.37% +0.02% - Complexity 4591 4592 +1 ============================================= Files 554 553 -1 Lines 20131 20118 -13 Branches 1045 1040 -5 ============================================= - Hits 12351 12348 -3 + Misses 7195 7191 -4 + Partials 585 579 -6 ``` | [Impacted Files](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3009?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [...om/faforever/client/game/GamesTableController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3009?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9nYW1lL0dhbWVzVGFibGVDb250cm9sbGVyLmphdmE=) | `51.28% <0.00%> (-0.42%)` | :arrow_down: | | [...ver/client/game/GamesTilesContainerController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3009?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9nYW1lL0dhbWVzVGlsZXNDb250YWluZXJDb250cm9sbGVyLmphdmE=) | `59.21% <40.00%> (-2.44%)` | :arrow_down: | | [...om/faforever/client/game/PlayerCardController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3009?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9nYW1lL1BsYXllckNhcmRDb250cm9sbGVyLmphdmE=) | `74.78% <46.15%> (-8.37%)` | :arrow_down: | | [...aforever/client/replay/ReplayDetailController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3009?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9yZXBsYXkvUmVwbGF5RGV0YWlsQ29udHJvbGxlci5qYXZh) | `79.13% <75.75%> (-3.00%)` | :arrow_down: | | [...m/faforever/client/game/GameTooltipController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3009?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9nYW1lL0dhbWVUb29sdGlwQ29udHJvbGxlci5qYXZh) | `87.80% <95.65%> (+7.80%)` | :arrow_up: | | [.../com/faforever/client/game/TeamCardController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3009?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9nYW1lL1RlYW1DYXJkQ29udHJvbGxlci5qYXZh) | `69.11% <95.65%> (+4.73%)` | :arrow_up: | | [...om/faforever/client/game/GameDetailController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3009?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9nYW1lL0dhbWVEZXRhaWxDb250cm9sbGVyLmphdmE=) | `91.66% <100.00%> (+1.75%)` | :arrow_up: | | [...ent/teammatchmaking/TeamMatchmakingController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3009?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC90ZWFtbWF0Y2htYWtpbmcvVGVhbU1hdGNobWFraW5nQ29udHJvbGxlci5qYXZh) | `91.46% <100.00%> (ø)` | | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3009/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3009?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3009?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [a8bb3b7...f5804ad](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3009?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).