FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
195 stars 121 forks source link

Message notifications appear, but no messages to be found #3012

Closed Garanas closed 1 year ago

Garanas commented 1 year ago

Describe the bug It appears I keep receiving notifications in chat messages in the client, but I can't see the message.

To Reproduce Try to have a conversation with someone, especially PMs but also Aeolus doesn't appear to always update.

Log or error message There are no logs that indicate something went wrong. I get a Windows notification (the red little circle with a number in it), I sometimes even hear a sound but then there's ... nothing. Sometimes someone sends me a message, the private chat tab is open but there's no message.

OS Windows

Garanas commented 1 year ago

image

As an example while being idle all day, they're all empty but the chats exist and I did receive the notifications (red number in app icon)

Garanas commented 1 year ago

I've received messages in Discord about the same bug, so it is not just me.

ChessBerry commented 1 year ago

Yeah I have the same problem, Has been around for at least a week as well

ChessBerry commented 1 year ago

Also note this, maybe relevant(?) correlation with the weird behavior when closing the client: https://github.com/FAForever/downlords-faf-client/issues/3016#issuecomment-1656281931

ChessBerry commented 1 year ago

Soo, had some time today to debug this a bit with @Garanas and Man_on_the_Moon.

In short: Not everyone seems to be effected by the bug in the same way. Some people, like @Garanas, Mize and me have the first (or more) messages we get sent by anyone vanish. Some others seem, like Man_on_the_Moon, seem(?) to have the chat working correctly for everyone, but people like the first group, and if they chat with them they have the same vanishing message problem. I'm not certain that these two groups truly experience different client behavior though, could be other factors explaining it.

The bug is very easy to reproduce though: Open a new chat with someone you haven't chatted this session yet, send them a message, and they'll have the chat window open but no message shown, exactly as jip describes above. In fact, if you send the first couple messages fast enough, you can even make more than one message disappear. Here for example I sent Jip the first msg twice and neither was shown to him:

It appears that the "vanishing" messages do actually arrive normally, as the message notification sound plays and the message preview of the content gets shown correctly too (most of the time?). Just the display of the messages in the chat window seems to be broken.

Some more testing with Man_on_the_Moon demonstrated that the bug is present in the 2023.6.0 and the 2023.7.0 versions of the client, but does not seem to exist in the 2023.5.0 version. Specifically, it seems that if you are on the 2023.5.0 version you can recieve messages perfectly fine but if messages you send appear for the other person depends their client version.

I'm not 100% on the 2023.5.0 actually not having this bug as I haven't tested it often enough and with enough people, but it seems to be promising. The release of 2023.6.0 possibly introducing the bug would also fit the time frame of the bug appearing "a couple weeks ago".

Some screenshots:

Sending messages from 2023.5.0 (CheeseBerry) to 2023.7.0 (Man_on_the_Moon) doesn't work, the first "x" message is missing:

This is reproducible:

Sending messages from 2023.7.0 (Man_on_the_Moon) to 2023.5.0 (CheeseBerry) does work, all 7 messages arrived:

After Man_on_the_Moon downgraded to 2023.5.0 as well, both sending and receiving messages works in both directions: Screenshot_270

ChessBerry commented 1 year ago

@Garanas Could you downgrade to 2023.5.0 as well and see if that fixes it for you?

ChessBerry commented 1 year ago

Well so much for that approach xd Screenshot_273

Sheikah45 commented 1 year ago

Should be fixed in 2023.7.1