search

FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
195 stars 121 forks source link

Closes #2992 Game, map, mod reviews average score filtering #3013

Closed bukajsytlos closed 1 year ago

bukajsytlos commented 1 year ago

Closes #2992 Game, map, mod reviews average score filtering

codecov[bot] commented 1 year ago

Codecov Report

Merging #3013 (3f24b80) into develop (65fc2f4) will increase coverage by 0.04%. The diff coverage is 66.03%.

:exclamation: Current head 3f24b80 differs from pull request most recent head 86fea7d. Consider uploading reports for the commit 86fea7d to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3013 +/- ## ============================================= + Coverage 59.31% 59.35% +0.04% - Complexity 4481 4490 +9 ============================================= Files 553 553 Lines 20119 20156 +37 Branches 1040 1040 ============================================= + Hits 11933 11964 +31 - Misses 7639 7645 +6 Partials 547 547 ``` | [Files Changed](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3013?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [...aforever/client/vault/search/SearchController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3013?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC92YXVsdC9zZWFyY2gvU2VhcmNoQ29udHJvbGxlci5qYXZh) | `54.38% <0.00%> (-0.49%)` | :arrow_down: | | [...om/faforever/client/domain/ReviewsSummaryBean.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3013?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9kb21haW4vUmV2aWV3c1N1bW1hcnlCZWFuLmphdmE=) | `72.97% <40.00%> (-5.16%)` | :arrow_down: | | [...ver/client/replay/OnlineReplayVaultController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3013?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9yZXBsYXkvT25saW5lUmVwbGF5VmF1bHRDb250cm9sbGVyLmphdmE=) | `75.00% <66.66%> (+0.27%)` | :arrow_up: | | [.../faforever/client/query/RangeFilterController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3013?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9xdWVyeS9SYW5nZUZpbHRlckNvbnRyb2xsZXIuamF2YQ==) | `78.66% <70.83%> (-2.04%)` | :arrow_down: | | [.../main/java/com/faforever/client/fx/JavaFxUtil.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3013?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9meC9KYXZhRnhVdGlsLmphdmE=) | `62.06% <83.33%> (+1.04%)` | :arrow_up: | | [...a/com/faforever/client/map/MapVaultController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3013?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9tYXAvTWFwVmF1bHRDb250cm9sbGVyLmphdmE=) | `67.04% <100.00%> (+0.37%)` | :arrow_up: | | [...a/com/faforever/client/mod/ModVaultController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3013?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9tb2QvTW9kVmF1bHRDb250cm9sbGVyLmphdmE=) | `60.00% <100.00%> (+0.54%)` | :arrow_up: | | [...rever/client/query/SearchablePropertyMappings.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3013?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9xdWVyeS9TZWFyY2hhYmxlUHJvcGVydHlNYXBwaW5ncy5qYXZh) | `98.21% <100.00%> (+0.03%)` | :arrow_up: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3013/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3013?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3013?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [65fc2f4...86fea7d](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3013?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).