search

FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
196 stars 121 forks source link

Use websockets for lobby connection #3037

Closed Sheikah45 closed 11 months ago

codecov[bot] commented 12 months ago

Codecov Report

Merging #3037 (ab5eafa) into develop (ef64c1d) will increase coverage by 0.03%. The diff coverage is 72.41%.

:exclamation: Current head ab5eafa differs from pull request most recent head 567b606. Consider uploading reports for the commit 567b606 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3037 +/- ## ============================================= + Coverage 59.29% 59.32% +0.03% - Complexity 4482 4492 +10 ============================================= Files 553 554 +1 Lines 20166 20167 +1 Branches 1037 1038 +1 ============================================= + Hits 11958 11965 +7 + Misses 7661 7653 -8 - Partials 547 549 +2 ``` | [Files](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [.../java/com/faforever/client/api/FafApiAccessor.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9hcGkvRmFmQXBpQWNjZXNzb3IuamF2YQ==) | `93.54% <100.00%> (-0.13%)` | :arrow_down: | | [...va/com/faforever/client/login/LoginController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9sb2dpbi9Mb2dpbkNvbnRyb2xsZXIuamF2YQ==) | `87.35% <100.00%> (-0.15%)` | :arrow_down: | | [.../java/com/faforever/client/remote/LobbyAccess.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9yZW1vdGUvTG9iYnlBY2Nlc3MuamF2YQ==) | `100.00% <100.00%> (ø)` | | | [...a/com/faforever/client/config/WebClientConfig.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jb25maWcvV2ViQ2xpZW50Q29uZmlnLmphdmE=) | `0.00% <0.00%> (ø)` | | | [...m/faforever/client/update/ClientConfiguration.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC91cGRhdGUvQ2xpZW50Q29uZmlndXJhdGlvbi5qYXZh) | `40.62% <50.00%> (-2.71%)` | :arrow_down: | | [...com/faforever/client/remote/FafServerAccessor.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9yZW1vdGUvRmFmU2VydmVyQWNjZXNzb3IuamF2YQ==) | `80.31% <84.61%> (+0.15%)` | :arrow_up: | | [.../com/faforever/client/config/ClientProperties.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jb25maWcvQ2xpZW50UHJvcGVydGllcy5qYXZh) | `52.41% <42.85%> (-2.06%)` | :arrow_down: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3037/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3037?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3037?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [ef64c1d...567b606](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3037?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).