FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
194 stars 119 forks source link

Make interaction with player names consistent #3041

Open BlackYps opened 9 months ago

BlackYps commented 9 months ago

There are various places in the client where the names of other players show up and you can interact with them. Typically by bringing up the context menu where you can add friend/foe, show user info etc. However the interaction to bring up the menu is inconsistent. The nicest implementation I found is in the replay window where the name gets highlighted and the cursor changes on mouseover and you bring up the menu with right or left click. We should do it this way everywhere.

Locations I found where it behaves differently: clicking on the name in aeolus chat directly: just opens up a direct chat instead of bringing up the menu name in the chat user list on the right: only right click works leaderboard: only right click works map or mod windod: you only have the option to copy the name on right click

The highlighting on mouseover to indicate that an interaction is possible is also different everywhere.