FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
196 stars 121 forks source link

Load the ICE servers from the new faf-icebreaker API #3043

Closed Brutus5000 closed 11 months ago

Brutus5000 commented 11 months ago

Right now this is an MVP approach for fast testing. The turn selection window still loads the old API and no longer makes sense, because we might want to use Xirsys for everyone. Needs more thought once DDoS is resolved.

codecov[bot] commented 11 months ago

Codecov Report

Merging #3043 (7a5c38e) into develop (3cea443) will decrease coverage by 0.06%. Report is 2 commits behind head on develop. The diff coverage is 77.27%.

:exclamation: Current head 7a5c38e differs from pull request most recent head fc6a69b. Consider uploading reports for the commit fc6a69b to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3043 +/- ## ============================================= - Coverage 59.31% 59.25% -0.06% + Complexity 4491 4484 -7 ============================================= Files 555 558 +3 Lines 20158 20156 -2 Branches 1035 1034 -1 ============================================= - Hits 11956 11943 -13 - Misses 7654 7665 +11 Partials 548 548 ``` | [Files](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3043?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [.../main/java/com/faforever/client/api/IceServer.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3043?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9hcGkvSWNlU2VydmVyLmphdmE=) | `100.00% <100.00%> (ø)` | | | [...main/java/com/faforever/client/api/IceSession.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3043?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9hcGkvSWNlU2Vzc2lvbi5qYXZh) | `100.00% <100.00%> (ø)` | | | [...m/faforever/client/fa/relay/ice/CoturnService.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3043?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9mYS9yZWxheS9pY2UvQ290dXJuU2VydmljZS5qYXZh) | `100.00% <100.00%> (ø)` | | | [.../faforever/client/fa/relay/ice/IceAdapterImpl.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3043?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9mYS9yZWxheS9pY2UvSWNlQWRhcHRlckltcGwuamF2YQ==) | `42.63% <ø> (-0.55%)` | :arrow_down: | | [...in/java/com/faforever/client/game/GameService.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3043?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9nYW1lL0dhbWVTZXJ2aWNlLmphdmE=) | `67.10% <100.00%> (ø)` | | | [...om/faforever/client/mapstruct/IceServerMapper.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3043?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9tYXBzdHJ1Y3QvSWNlU2VydmVyTWFwcGVyLmphdmE=) | `100.00% <ø> (ø)` | | | [...orever/client/preferences/ForgedAlliancePrefs.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3043?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9wcmVmZXJlbmNlcy9Gb3JnZWRBbGxpYW5jZVByZWZzLmphdmE=) | `76.66% <ø> (-1.80%)` | :arrow_down: | | [...ever/client/preferences/ui/SettingsController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3043?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9wcmVmZXJlbmNlcy91aS9TZXR0aW5nc0NvbnRyb2xsZXIuamF2YQ==) | `81.45% <100.00%> (-0.06%)` | :arrow_down: | | [...va/com/faforever/client/api/IceServerResponse.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3043?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9hcGkvSWNlU2VydmVyUmVzcG9uc2UuamF2YQ==) | `0.00% <0.00%> (ø)` | | | [.../java/com/faforever/client/api/FafApiAccessor.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3043?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9hcGkvRmFmQXBpQWNjZXNzb3IuamF2YQ==) | `91.19% <33.33%> (-2.36%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3043/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3043?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3043?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [23d12b2...fc6a69b](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3043?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).