FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
196 stars 121 forks source link

Add mod search feature #3049

Closed Kimo-s closed 10 months ago

Kimo-s commented 10 months ago

This is for the issue: #1804

Added a simple text field for the mod selection before start the game to search for mod and select them. Some UI changes might be desired and I can change accordingly.

codecov[bot] commented 10 months ago

Codecov Report

Merging #3049 (94cafc4) into develop (8ddd12c) will decrease coverage by 0.04%. The diff coverage is 60.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3049 +/- ## ============================================= - Coverage 58.91% 58.87% -0.04% + Complexity 4458 4453 -5 ============================================= Files 558 558 Lines 20156 20159 +3 Branches 1034 1035 +1 ============================================= - Hits 11874 11868 -6 - Misses 7736 7742 +6 - Partials 546 549 +3 ``` | [Files](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3049?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [...com/faforever/client/mod/ModManagerController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3049?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9tb2QvTW9kTWFuYWdlckNvbnRyb2xsZXIuamF2YQ==) | `55.88% <60.00%> (-2.58%)` | :arrow_down: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3049/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3049?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3049?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [8ddd12c...94cafc4](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3049?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).
Sheikah45 commented 10 months ago

Can you also add spacing between the search bar and the toggles?

image