search

FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
196 stars 121 forks source link

Tweaked CSS Code for Main Header #3052

Closed MrRowey closed 10 months ago

MrRowey commented 10 months ago

@Sheikah45 This is just a Simple CSS change increasing the Top header padding from 9 -> 20 in windowed mode and 0 -> 20px when in full-screen

codecov[bot] commented 10 months ago

Codecov Report

Merging #3052 (0a2e709) into develop (6b577f7) will decrease coverage by 0.01%. The diff coverage is n/a.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3052 +/- ## ============================================= - Coverage 58.88% 58.87% -0.01% Complexity 4454 4454 ============================================= Files 558 558 Lines 20159 20159 Branches 1035 1035 ============================================= - Hits 11870 11868 -2 - Misses 7740 7742 +2 Partials 549 549 ``` [see 1 file with indirect coverage changes](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3052/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3052?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3052?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [6b577f7...0a2e709](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3052?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).
Sheikah45 commented 10 months ago

I took a look deeper further into this and found a better solution of using the title bar as intended so that we get the full intended interactions. See #3056