FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
196 stars 121 forks source link

Chat up and down arrow key scrolls over chat channel message history #3059

Closed Kimo-s closed 9 months ago

Kimo-s commented 10 months ago

2881

codecov[bot] commented 10 months ago

Codecov Report

Merging #3059 (9a284d5) into develop (47ef44e) will decrease coverage by 0.08%. The diff coverage is 28.57%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3059 +/- ## ============================================= - Coverage 58.98% 58.90% -0.08% + Complexity 4458 4455 -3 ============================================= Files 561 561 Lines 20322 20350 +28 Branches 1025 1033 +8 ============================================= + Hits 11987 11988 +1 - Misses 7790 7813 +23 - Partials 545 549 +4 ``` | [Files](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3059?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [...om/faforever/client/chat/ChannelTabController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3059?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L0NoYW5uZWxUYWJDb250cm9sbGVyLmphdmE=) | `85.85% <ø> (ø)` | | | [...forever/client/chat/AbstractChatTabController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3059?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L0Fic3RyYWN0Q2hhdFRhYkNvbnRyb2xsZXIuamF2YQ==) | `69.50% <28.57%> (-3.67%)` | :arrow_down: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3059/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3059?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3059?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [47ef44e...9a284d5](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3059?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).
Sheikah45 commented 10 months ago

Now that the state overhaul has been deployed you can use this with the chat messages kept in the chatChannel object once you rebase