FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
194 stars 119 forks source link

Move reconnect handling to faf server accessor #3061

Closed Sheikah45 closed 7 months ago

codecov[bot] commented 7 months ago

Codecov Report

Merging #3061 (7ca7086) into develop (8144555) will increase coverage by 0.01%. The diff coverage is 77.58%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3061 +/- ## ============================================= + Coverage 58.86% 58.87% +0.01% + Complexity 4455 4452 -3 ============================================= Files 558 558 Lines 20160 20186 +26 Branches 1035 1035 ============================================= + Hits 11867 11885 +18 - Misses 7745 7750 +5 - Partials 548 551 +3 ``` | [Files](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3061?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [.../com/faforever/client/config/ClientProperties.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3061?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jb25maWcvQ2xpZW50UHJvcGVydGllcy5qYXZh) | `52.41% <100.00%> (ø)` | | | [...com/faforever/client/remote/FafServerAccessor.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3061?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9yZW1vdGUvRmFmU2VydmVyQWNjZXNzb3IuamF2YQ==) | `80.40% <76.78%> (-0.75%)` | :arrow_down: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3061/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3061?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3061?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [8144555...7ca7086](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3061?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).