search

FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
194 stars 119 forks source link

Removed the use priority settings #3062

Closed Kimo-s closed 7 months ago

Kimo-s commented 7 months ago

3057

codecov[bot] commented 7 months ago

Codecov Report

Merging #3062 (8277852) into develop (edbbef8) will increase coverage by 0.02%. The diff coverage is n/a.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3062 +/- ## ============================================= + Coverage 58.78% 58.81% +0.02% Complexity 4459 4459 ============================================= Files 560 560 Lines 20401 20391 -10 Branches 1028 1027 -1 ============================================= Hits 11993 11993 + Misses 7862 7854 -8 + Partials 546 544 -2 ``` | [Files](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3062?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [...com/faforever/client/fa/ForgedAllianceService.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3062?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9mYS9Gb3JnZWRBbGxpYW5jZVNlcnZpY2UuamF2YQ==) | `84.84% <ø> (+3.68%)` | :arrow_up: | | [...orever/client/preferences/ForgedAlliancePrefs.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3062?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9wcmVmZXJlbmNlcy9Gb3JnZWRBbGxpYW5jZVByZWZzLmphdmE=) | `80.00% <ø> (+3.33%)` | :arrow_up: | | [...ever/client/preferences/ui/SettingsController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3062?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9wcmVmZXJlbmNlcy91aS9TZXR0aW5nc0NvbnRyb2xsZXIuamF2YQ==) | `75.22% <ø> (-0.16%)` | :arrow_down: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3062/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3062?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3062?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [edbbef8...8277852](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3062?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).
Sheikah45 commented 7 months ago

The builds are failing when you remove the fields you also have to fix wherever they are used