search

FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
194 stars 117 forks source link

Use records over value #3067

Closed Sheikah45 closed 7 months ago

codecov[bot] commented 7 months ago

Codecov Report

Merging #3067 (d093ffc) into develop (c03f1a1) will increase coverage by 0.16%. The diff coverage is 78.66%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3067 +/- ## ============================================= + Coverage 58.81% 58.97% +0.16% - Complexity 4459 4461 +2 ============================================= Files 560 560 Lines 20391 20294 -97 Branches 1027 1025 -2 ============================================= - Hits 11992 11968 -24 + Misses 7854 7783 -71 + Partials 545 543 -2 ``` | [Files](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3067?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [...ava/com/faforever/client/chat/ChatChannelUser.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3067?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L0NoYXRDaGFubmVsVXNlci5qYXZh) | `93.33% <100.00%> (-0.61%)` | :arrow_down: | | [...om/faforever/client/domain/AbstractEntityBean.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3067?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9kb21haW4vQWJzdHJhY3RFbnRpdHlCZWFuLmphdmE=) | `84.21% <100.00%> (ø)` | | | [...n/java/com/faforever/client/domain/AvatarBean.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3067?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9kb21haW4vQXZhdGFyQmVhbi5qYXZh) | `83.33% <100.00%> (ø)` | | | [...ain/java/com/faforever/client/domain/ClanBean.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3067?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9kb21haW4vQ2xhbkJlYW4uamF2YQ==) | `75.00% <100.00%> (ø)` | | | [...a/com/faforever/client/domain/CoopMissionBean.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3067?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9kb21haW4vQ29vcE1pc3Npb25CZWFuLmphdmE=) | `75.00% <100.00%> (ø)` | | | [...va/com/faforever/client/domain/CoopResultBean.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3067?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9kb21haW4vQ29vcFJlc3VsdEJlYW4uamF2YQ==) | `78.12% <100.00%> (ø)` | | | [...java/com/faforever/client/domain/DivisionBean.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3067?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9kb21haW4vRGl2aXNpb25CZWFuLmphdmE=) | `73.91% <100.00%> (ø)` | | | [...a/com/faforever/client/domain/FeaturedModBean.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3067?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9kb21haW4vRmVhdHVyZWRNb2RCZWFuLmphdmE=) | `81.08% <100.00%> (ø)` | | | [...ain/java/com/faforever/client/domain/GameBean.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3067?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9kb21haW4vR2FtZUJlYW4uamF2YQ==) | `89.34% <100.00%> (ø)` | | | [...m/faforever/client/domain/GamePlayerStatsBean.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3067?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9kb21haW4vR2FtZVBsYXllclN0YXRzQmVhbi5qYXZh) | `74.35% <100.00%> (ø)` | | | ... and [78 more](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3067?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3067/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3067?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3067?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [c03f1a1...d093ffc](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3067?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).