search

FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
196 stars 121 forks source link

Use getFirst where applicable #3068

Closed Sheikah45 closed 10 months ago

codecov[bot] commented 10 months ago

Codecov Report

Merging #3068 (3e7086d) into develop (6045e3d) will increase coverage by 0.04%. The diff coverage is 61.11%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3068 +/- ## ============================================= + Coverage 58.90% 58.95% +0.04% - Complexity 4457 4460 +3 ============================================= Files 560 560 Lines 20294 20294 Branches 1025 1025 ============================================= + Hits 11955 11965 +10 + Misses 7795 7785 -10 Partials 544 544 ``` | [Files](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3068?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [...ever/client/chat/emoticons/EmoticonController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3068?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L2Vtb3RpY29ucy9FbW90aWNvbkNvbnRyb2xsZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | | | [...r/client/filter/FilterMultiCheckboxController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3068?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9maWx0ZXIvRmlsdGVyTXVsdGlDaGVja2JveENvbnRyb2xsZXIuamF2YQ==) | `87.03% <100.00%> (ø)` | | | [.../com/faforever/client/game/GameTileController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3068?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9nYW1lL0dhbWVUaWxlQ29udHJvbGxlci5qYXZh) | `94.28% <100.00%> (ø)` | | | [...va/com/faforever/client/login/LoginController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3068?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9sb2dpbi9Mb2dpbkNvbnRyb2xsZXIuamF2YQ==) | `87.93% <100.00%> (ø)` | | | [.../faforever/client/tutorial/TutorialController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3068?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC90dXRvcmlhbC9UdXRvcmlhbENvbnRyb2xsZXIuamF2YQ==) | `86.53% <100.00%> (ø)` | | | [...er/client/vault/search/SavedQueriesController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3068?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC92YXVsdC9zZWFyY2gvU2F2ZWRRdWVyaWVzQ29udHJvbGxlci5qYXZh) | `79.16% <100.00%> (ø)` | | | [...textmenu/AvatarPickerCustomMenuItemController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3068?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9meC9jb250ZXh0bWVudS9BdmF0YXJQaWNrZXJDdXN0b21NZW51SXRlbUNvbnRyb2xsZXIuamF2YQ==) | `87.09% <0.00%> (ø)` | | | [...m/faforever/client/game/CustomGamesController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3068?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9nYW1lL0N1c3RvbUdhbWVzQ29udHJvbGxlci5qYXZh) | `61.53% <0.00%> (ø)` | | | [...om/faforever/client/game/GamesTableController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3068?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9nYW1lL0dhbWVzVGFibGVDb250cm9sbGVyLmphdmE=) | `49.56% <0.00%> (ø)` | | | [...ver/client/game/GamesTilesContainerController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3068?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9nYW1lL0dhbWVzVGlsZXNDb250YWluZXJDb250cm9sbGVyLmphdmE=) | `58.94% <0.00%> (ø)` | | | ... and [3 more](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3068?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3068/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3068?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3068?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [6045e3d...3e7086d](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3068?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).