search

FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
194 stars 117 forks source link

Move exceptionally after spawnTerminationListener #3069

Closed Sheikah45 closed 7 months ago

codecov[bot] commented 7 months ago

Codecov Report

Merging #3069 (d28850b) into develop (9902ec4) will decrease coverage by 0.01%. The diff coverage is 50.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3069 +/- ## ============================================= - Coverage 58.91% 58.91% -0.01% - Complexity 4454 4457 +3 ============================================= Files 560 560 Lines 20294 20293 -1 Branches 1025 1025 ============================================= - Hits 11957 11955 -2 - Misses 7792 7795 +3 + Partials 545 543 -2 ``` | [Files](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3069?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [...in/java/com/faforever/client/game/GameService.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3069?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9nYW1lL0dhbWVTZXJ2aWNlLmphdmE=) | `68.55% <100.00%> (-0.88%)` | :arrow_down: | | [...com/faforever/client/fa/ForgedAllianceService.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3069?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9mYS9Gb3JnZWRBbGxpYW5jZVNlcnZpY2UuamF2YQ==) | `86.15% <0.00%> (+1.30%)` | :arrow_up: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3069/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3069?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3069?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [9902ec4...d28850b](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3069?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).