search

FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
196 stars 121 forks source link

Don't load webViews in fxml #3071

Open Sheikah45 opened 10 months ago

codecov[bot] commented 10 months ago

Codecov Report

Merging #3071 (87d7912) into develop (d87f32f) will increase coverage by 0.03%. The diff coverage is 48.35%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3071 +/- ## ============================================= + Coverage 58.84% 58.88% +0.03% - Complexity 4446 4456 +10 ============================================= Files 560 560 Lines 20293 20326 +33 Branches 1025 1025 ============================================= + Hits 11942 11969 +27 - Misses 7807 7815 +8 + Partials 544 542 -2 ``` | [Files](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3071?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [...forever/client/chat/AbstractChatTabController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3071?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L0Fic3RyYWN0Q2hhdFRhYkNvbnRyb2xsZXIuamF2YQ==) | `72.99% <100.00%> (-0.18%)` | :arrow_down: | | [...om/faforever/client/chat/ChannelTabController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3071?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L0NoYW5uZWxUYWJDb250cm9sbGVyLmphdmE=) | `86.20% <100.00%> (+0.34%)` | :arrow_up: | | [.../java/com/faforever/client/theme/ThemeService.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3071?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC90aGVtZS9UaGVtZVNlcnZpY2UuamF2YQ==) | `0.93% <ø> (ø)` | | | [...forever/client/chat/MatchmakingChatController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3071?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L01hdGNobWFraW5nQ2hhdENvbnRyb2xsZXIuamF2YQ==) | `57.14% <83.33%> (+2.59%)` | :arrow_up: | | [...aforever/client/chat/PrivateChatTabController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3071?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L1ByaXZhdGVDaGF0VGFiQ29udHJvbGxlci5qYXZh) | `63.23% <83.33%> (+1.33%)` | :arrow_up: | | [...java/com/faforever/client/coop/CoopController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3071?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jb29wL0Nvb3BDb250cm9sbGVyLmphdmE=) | `58.22% <83.33%> (+0.80%)` | :arrow_up: | | [...ent/notification/ServerNotificationController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3071?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9ub3RpZmljYXRpb24vU2VydmVyTm90aWZpY2F0aW9uQ29udHJvbGxlci5qYXZh) | `65.11% <88.88%> (+2.61%)` | :arrow_up: | | [...ever/client/tutorial/TutorialDetailController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3071?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC90dXRvcmlhbC9UdXRvcmlhbERldGFpbENvbnRyb2xsZXIuamF2YQ==) | `80.00% <90.00%> (ø)` | | | [...rever/client/tournament/TournamentsController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3071?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC90b3VybmFtZW50L1RvdXJuYW1lbnRzQ29udHJvbGxlci5qYXZh) | `0.00% <0.00%> (ø)` | | | [...va/com/faforever/client/units/UnitsController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3071?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC91bml0cy9Vbml0c0NvbnRyb2xsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | | | ... and [2 more](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3071?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | | ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3071/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3071?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3071?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [d87f32f...87d7912](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3071?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).