FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
196 stars 121 forks source link

Copy map name in replay detail screen only #3072

Closed obydog002 closed 10 months ago

obydog002 commented 10 months ago

Fix #2959

Only copy the map name by removing the 'on' part. I don't know if this makes the most sense as it doesn't match the style in other windows (for example the 'FAF Replays' tab under Replays) but it also looks nice.

codecov[bot] commented 10 months ago

Codecov Report

Merging #3072 (0504f85) into develop (d87f32f) will increase coverage by 0.04%. The diff coverage is n/a.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3072 +/- ## ============================================= + Coverage 58.84% 58.89% +0.04% - Complexity 4446 4449 +3 ============================================= Files 560 560 Lines 20293 20292 -1 Branches 1025 1025 ============================================= + Hits 11942 11950 +8 + Misses 7807 7798 -9 Partials 544 544 ``` | [Files](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3072?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [...aforever/client/replay/ReplayDetailController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3072?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9yZXBsYXkvUmVwbGF5RGV0YWlsQ29udHJvbGxlci5qYXZh) | `78.40% <ø> (-0.08%)` | :arrow_down: | ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3072/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3072?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3072?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [d87f32f...0504f85](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3072?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).