FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
194 stars 117 forks source link

Clean up TODOs #3074

Closed Sheikah45 closed 7 months ago

codecov[bot] commented 7 months ago

Codecov Report

Merging #3074 (ba76176) into develop (64d4ba8) will increase coverage by 0.00%. The diff coverage is n/a.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3074 +/- ## ========================================== Coverage 58.89% 58.90% + Complexity 4450 4449 -1 ========================================== Files 560 560 Lines 20292 20292 Branches 1025 1025 ========================================== + Hits 11951 11952 +1 + Misses 7798 7796 -2 - Partials 543 544 +1 ``` | [Files](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3074?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [...ava/com/faforever/client/FafClientApplication.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3074?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9GYWZDbGllbnRBcHBsaWNhdGlvbi5qYXZh) | `2.77% <ø> (ø)` | | | [...m/faforever/client/clan/ClanTooltipController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3074?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jbGFuL0NsYW5Ub29sdGlwQ29udHJvbGxlci5qYXZh) | `0.00% <ø> (ø)` | | | [...rever/client/notification/NotificationService.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3074?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9ub3RpZmljYXRpb24vTm90aWZpY2F0aW9uU2VydmljZS5qYXZh) | `46.51% <ø> (ø)` | | | [.../faforever/client/replay/ReplayCardController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3074?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9yZXBsYXkvUmVwbGF5Q2FyZENvbnRyb2xsZXIuamF2YQ==) | `0.00% <ø> (ø)` | | | [...lient/tournament/TournamentListItemController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3074?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC90b3VybmFtZW50L1RvdXJuYW1lbnRMaXN0SXRlbUNvbnRyb2xsZXIuamF2YQ==) | `0.00% <ø> (ø)` | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3074/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3074?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3074?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [64d4ba8...ba76176](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3074?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).