search

FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
194 stars 117 forks source link

Create separate FeaturedModService #3075

Closed Sheikah45 closed 7 months ago

codecov[bot] commented 7 months ago

Codecov Report

Merging #3075 (ebb4b77) into develop (64d4ba8) will decrease coverage by 0.03%. Report is 1 commits behind head on develop. The diff coverage is 78.78%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3075 +/- ## ============================================= - Coverage 58.89% 58.87% -0.03% + Complexity 4450 4449 -1 ============================================= Files 560 561 +1 Lines 20292 20298 +6 Branches 1025 1025 ============================================= - Hits 11951 11950 -1 - Misses 7798 7801 +3 - Partials 543 547 +4 ``` | [Files](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3075?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [...ava/com/faforever/client/FafClientApplication.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3075?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9GYWZDbGllbnRBcHBsaWNhdGlvbi5qYXZh) | `2.77% <ø> (ø)` | | | [...m/faforever/client/clan/ClanTooltipController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3075?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jbGFuL0NsYW5Ub29sdGlwQ29udHJvbGxlci5qYXZh) | `0.00% <ø> (ø)` | | | [...java/com/faforever/client/coop/CoopController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3075?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jb29wL0Nvb3BDb250cm9sbGVyLmphdmE=) | `57.41% <100.00%> (ø)` | | | [...ver/client/filter/CustomGamesFilterController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3075?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9maWx0ZXIvQ3VzdG9tR2FtZXNGaWx0ZXJDb250cm9sbGVyLmphdmE=) | `100.00% <100.00%> (ø)` | | | [...rever/client/filter/LiveGamesFilterController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3075?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9maWx0ZXIvTGl2ZUdhbWVzRmlsdGVyQ29udHJvbGxlci5qYXZh) | `80.00% <100.00%> (ø)` | | | [...om/faforever/client/game/CreateGameController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3075?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9nYW1lL0NyZWF0ZUdhbWVDb250cm9sbGVyLmphdmE=) | `69.85% <100.00%> (ø)` | | | [...om/faforever/client/game/GameDetailController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3075?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9nYW1lL0dhbWVEZXRhaWxDb250cm9sbGVyLmphdmE=) | `94.69% <100.00%> (ø)` | | | [...java/com/faforever/client/mapstruct/ModMapper.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3075?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9tYXBzdHJ1Y3QvTW9kTWFwcGVyLmphdmE=) | `66.66% <ø> (ø)` | | | [...main/java/com/faforever/client/mod/ModService.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3075?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9tb2QvTW9kU2VydmljZS5qYXZh) | `73.72% <ø> (-2.03%)` | :arrow_down: | | [...rever/client/notification/NotificationService.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3075?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9ub3RpZmljYXRpb24vTm90aWZpY2F0aW9uU2VydmljZS5qYXZh) | `46.51% <ø> (ø)` | | | ... and [11 more](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3075?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3075/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3075?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3075?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [44f68e2...ebb4b77](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3075?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).