search

FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
196 stars 121 forks source link

Fix issue with persistent_notification.fxml #3080

Closed Sheikah45 closed 9 months ago

Sheikah45 commented 9 months ago

Closes #3079

codecov[bot] commented 9 months ago

Codecov Report

Merging #3080 (8016335) into develop (64637a0) will increase coverage by 0.00%. The diff coverage is 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3080 +/- ## ========================================== Coverage 58.96% 58.97% Complexity 4455 4455 ========================================== Files 561 561 Lines 20320 20322 +2 Branches 1025 1025 ========================================== + Hits 11982 11985 +3 + Misses 7792 7790 -2 - Partials 546 547 +1 ``` | [Files](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3080?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [...notification/PersistentNotificationController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3080?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9ub3RpZmljYXRpb24vUGVyc2lzdGVudE5vdGlmaWNhdGlvbkNvbnRyb2xsZXIuamF2YQ==) | `85.36% <100.00%> (+0.75%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3080/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3080?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3080?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [64637a0...8016335](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3080?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).