search

FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
194 stars 117 forks source link

Consolidate game start logic #3081

Closed Sheikah45 closed 6 months ago

codecov[bot] commented 7 months ago

Codecov Report

Merging #3081 (5b586c8) into develop (47ef44e) will decrease coverage by 0.02%. Report is 1 commits behind head on develop. The diff coverage is 59.47%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3081 +/- ## ============================================= - Coverage 58.98% 58.97% -0.02% + Complexity 4458 4412 -46 ============================================= Files 561 561 Lines 20322 20179 -143 Branches 1025 1030 +5 ============================================= - Hits 11987 11900 -87 + Misses 7790 7740 -50 + Partials 545 539 -6 ``` | [Files](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3081?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [...om/faforever/client/chat/ChannelTabController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3081?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L0NoYW5uZWxUYWJDb250cm9sbGVyLmphdmE=) | `85.85% <ø> (ø)` | | | [...java/com/faforever/client/coop/CoopController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3081?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jb29wL0Nvb3BDb250cm9sbGVyLmphdmE=) | `58.62% <100.00%> (+1.20%)` | :arrow_up: | | [...ain/java/com/faforever/client/domain/GameBean.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3081?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9kb21haW4vR2FtZUJlYW4uamF2YQ==) | `89.74% <ø> (+0.39%)` | :arrow_up: | | [...n/java/com/faforever/client/fa/GameParameters.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3081?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9mYS9HYW1lUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (+5.55%)` | :arrow_up: | | [.../faforever/client/fa/relay/ice/IceAdapterImpl.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3081?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9mYS9yZWxheS9pY2UvSWNlQWRhcHRlckltcGwuamF2YQ==) | `40.49% <ø> (-0.97%)` | :arrow_down: | | [...orever/client/fx/contextmenu/JoinGameMenuItem.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3081?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9meC9jb250ZXh0bWVudS9Kb2luR2FtZU1lbnVJdGVtLmphdmE=) | `83.33% <100.00%> (ø)` | | | [...rever/client/fx/contextmenu/WatchGameMenuItem.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3081?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9meC9jb250ZXh0bWVudS9XYXRjaEdhbWVNZW51SXRlbS5qYXZh) | `100.00% <100.00%> (ø)` | | | [...faforever/client/game/EnterPasswordController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3081?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9nYW1lL0VudGVyUGFzc3dvcmRDb250cm9sbGVyLmphdmE=) | `0.00% <ø> (ø)` | | | [...om/faforever/client/game/GameDetailController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3081?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9nYW1lL0dhbWVEZXRhaWxDb250cm9sbGVyLmphdmE=) | `94.69% <100.00%> (ø)` | | | [...in/java/com/faforever/client/game/GameService.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3081?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9nYW1lL0dhbWVTZXJ2aWNlLmphdmE=) | `94.33% <100.00%> (+25.78%)` | :arrow_up: | | ... and [48 more](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3081?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | | ... and [7 files with indirect coverage changes](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3081/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3081?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3081?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [aeabfe0...5b586c8](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3081?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).