search

FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
194 stars 117 forks source link

Add a biome selector to the map generation dialog #3085

Closed BlackYps closed 6 months ago

BlackYps commented 6 months ago

Requires https://github.com/FAForever/Neroxis-Map-Generator/pull/382 to be merged and released to actually be able to load the biomes list

grafik

codecov[bot] commented 6 months ago

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (2b15d9b) 59.02% compared to head (9805ecb) 59.10%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3085 +/- ## ============================================= + Coverage 59.02% 59.10% +0.08% - Complexity 4408 4415 +7 ============================================= Files 565 565 Lines 20086 20122 +36 Branches 989 990 +1 ============================================= + Hits 11856 11894 +38 + Misses 7713 7710 -3 - Partials 517 518 +1 ``` | [Files](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3085?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [...om/faforever/client/game/CreateGameController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3085?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9nYW1lL0NyZWF0ZUdhbWVDb250cm9sbGVyLmphdmE=) | `70.58% <100.00%> (+0.10%)` | :arrow_up: | | [...m/faforever/client/game/GenerateMapController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3085?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9nYW1lL0dlbmVyYXRlTWFwQ29udHJvbGxlci5qYXZh) | `83.65% <100.00%> (+2.03%)` | :arrow_up: | | [...m/faforever/client/preferences/GeneratorPrefs.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3085?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9wcmVmZXJlbmNlcy9HZW5lcmF0b3JQcmVmcy5qYXZh) | `87.50% <100.00%> (+0.68%)` | :arrow_up: | | [...ever/client/map/generator/MapGeneratorService.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3085?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9tYXAvZ2VuZXJhdG9yL01hcEdlbmVyYXRvclNlcnZpY2UuamF2YQ==) | `50.51% <0.00%> (-3.93%)` | :arrow_down: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3085/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3085?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3085?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [2b15d9b...9805ecb](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3085?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).
BlackYps commented 6 months ago

Now that the text for random style and biome is the same, should the two constants GENERATOR_RANDOM_STYLE and GENERATOR_RANDOM_BIOME be consolidated into one?