search

FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
194 stars 117 forks source link

Reduce chat tab dependencies #3086

Closed Sheikah45 closed 6 months ago

codecov[bot] commented 6 months ago

Codecov Report

Merging #3086 (4011ed7) into develop (2827411) will increase coverage by 0.15%. The diff coverage is 77.68%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3086 +/- ## ============================================= + Coverage 58.93% 59.08% +0.15% - Complexity 4406 4421 +15 ============================================= Files 561 560 -1 Lines 20179 20187 +8 Branches 1030 1021 -9 ============================================= + Hits 11892 11927 +35 + Misses 7746 7719 -27 Partials 541 541 ``` | [Files](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3086?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [.../java/com/faforever/client/audio/AudioService.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3086?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9hdWRpby9BdWRpb1NlcnZpY2UuamF2YQ==) | `100.00% <100.00%> (ø)` | | | [...om/faforever/client/chat/ChannelTabController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3086?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L0NoYW5uZWxUYWJDb250cm9sbGVyLmphdmE=) | `85.10% <100.00%> (-0.76%)` | :arrow_down: | | [...n/java/com/faforever/client/chat/ChannelTopic.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3086?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L0NoYW5uZWxUb3BpYy5qYXZh) | `100.00% <100.00%> (ø)` | | | [...in/java/com/faforever/client/chat/ChatChannel.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3086?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L0NoYXRDaGFubmVsLmphdmE=) | `79.59% <100.00%> (ø)` | | | [...in/java/com/faforever/client/chat/ChatMessage.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3086?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L0NoYXRNZXNzYWdlLmphdmE=) | `100.00% <100.00%> (ø)` | | | [...in/java/com/faforever/client/chat/ChatService.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3086?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L0NoYXRTZXJ2aWNlLmphdmE=) | `0.00% <ø> (ø)` | | | [...va/com/faforever/client/chat/ChatUserCategory.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3086?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L0NoYXRVc2VyQ2F0ZWdvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | | | [...forever/client/chat/MatchmakingChatController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3086?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L01hdGNobWFraW5nQ2hhdENvbnRyb2xsZXIuamF2YQ==) | `60.41% <100.00%> (+3.59%)` | :arrow_up: | | [...n/java/com/faforever/client/domain/PlayerBean.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3086?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9kb21haW4vUGxheWVyQmVhbi5qYXZh) | `95.38% <ø> (+1.53%)` | :arrow_up: | | [...aforever/client/chat/PrivateChatTabController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3086?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L1ByaXZhdGVDaGF0VGFiQ29udHJvbGxlci5qYXZh) | `63.63% <92.85%> (+1.73%)` | :arrow_up: | | ... and [3 more](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3086?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | | ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3086/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3086?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3086?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [2827411...4011ed7](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3086?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).