search

FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
196 stars 121 forks source link

Simplify notification service #3087

Closed Sheikah45 closed 9 months ago

codecov[bot] commented 9 months ago

Codecov Report

Merging #3087 (4b45968) into develop (7e1f13d) will increase coverage by 0.00%. The diff coverage is 29.31%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3087 +/- ## ========================================== Coverage 59.07% 59.08% + Complexity 4422 4409 -13 ========================================== Files 560 562 +2 Lines 20187 20151 -36 Branches 1021 1013 -8 ========================================== - Hits 11926 11906 -20 + Misses 7721 7707 -14 + Partials 540 538 -2 ``` | [Files](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3087?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [...forever/client/chat/AbstractChatTabController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3087?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L0Fic3RyYWN0Q2hhdFRhYkNvbnRyb2xsZXIuamF2YQ==) | `71.75% <ø> (ø)` | | | [...java/com/faforever/client/coop/CoopController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3087?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jb29wL0Nvb3BDb250cm9sbGVyLmphdmE=) | `58.62% <100.00%> (ø)` | | | [...java/com/faforever/client/fa/GameFullNotifier.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3087?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9mYS9HYW1lRnVsbE5vdGlmaWVyLmphdmE=) | `87.50% <ø> (ø)` | | | [...orever/client/fx/contextmenu/AbstractMenuItem.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3087?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9meC9jb250ZXh0bWVudS9BYnN0cmFjdE1lbnVJdGVtLmphdmE=) | `100.00% <ø> (ø)` | | | [...ava/com/faforever/client/game/GamePathHandler.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3087?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9nYW1lL0dhbWVQYXRoSGFuZGxlci5qYXZh) | `35.18% <100.00%> (+0.63%)` | :arrow_up: | | [...va/com/faforever/client/game/VaultPathHandler.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3087?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9nYW1lL1ZhdWx0UGF0aEhhbmRsZXIuamF2YQ==) | `66.66% <100.00%> (+1.96%)` | :arrow_up: | | [...ver/client/notification/ImmediateNotification.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3087?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9ub3RpZmljYXRpb24vSW1tZWRpYXRlTm90aWZpY2F0aW9uLmphdmE=) | `55.55% <100.00%> (-17.78%)` | :arrow_down: | | [...er/client/notification/PersistentNotification.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3087?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9ub3RpZmljYXRpb24vUGVyc2lzdGVudE5vdGlmaWNhdGlvbi5qYXZh) | `75.00% <100.00%> (-25.00%)` | :arrow_down: | | [...va/com/faforever/client/notification/Severity.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3087?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9ub3RpZmljYXRpb24vU2V2ZXJpdHkuamF2YQ==) | `100.00% <ø> (ø)` | | | [...ver/client/notification/TransientNotification.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3087?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9ub3RpZmljYXRpb24vVHJhbnNpZW50Tm90aWZpY2F0aW9uLmphdmE=) | `83.33% <100.00%> (+23.33%)` | :arrow_up: | | ... and [39 more](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3087?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3087/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3087?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3087?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [7e1f13d...4b45968](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3087?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).