search

FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
194 stars 117 forks source link

Select map when it is added when the create game dialog is open #3094

Closed Sheikah45 closed 6 months ago

Sheikah45 commented 6 months ago

Closes #3091

codecov[bot] commented 6 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (1c474e1) 59.05% compared to head (00ddd02) 59.10%. Report is 2 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3094 +/- ## ============================================= + Coverage 59.05% 59.10% +0.04% - Complexity 4409 4411 +2 ============================================= Files 562 562 Lines 20151 20159 +8 Branches 1013 1014 +1 ============================================= + Hits 11900 11914 +14 + Misses 7713 7705 -8 - Partials 538 540 +2 ``` | [Files](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3094?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [...om/faforever/client/game/CreateGameController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3094?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9nYW1lL0NyZWF0ZUdhbWVDb250cm9sbGVyLmphdmE=) | `70.48% <92.30%> (+0.59%)` | :arrow_up: | | [...java/com/faforever/client/replay/ReplayRunner.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3094?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9yZXBsYXkvUmVwbGF5UnVubmVyLmphdmE=) | `90.24% <66.66%> (-0.12%)` | :arrow_down: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3094/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3094?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3094?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [2956536...00ddd02](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3094?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).